Bug 1790234 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Marco Bonardo [:mak] from comment #3)
> You don't need a new API afaict, you can use replaceFaviconData or replaceFaviconDataFromDataURL depending on which format you have the icon, followed by setAndFetchFaviconForPage. The former fills a memory cache that is then used by the latter, so network won't be hit as far as the faviconURI is the same.
> Fetching from the network directly in the favicon service is deprecated, long term I think the service will only accept a data url for the favicon data.
> 
> If you don't have the favicon uri, then you'll have to make a "randomized" one, but I hope other browsers are storing the favicon uri.
> 
> Note: the annoyance of having to invoke 2 APIs for setting one icon could be removed, and we have Bug 1552815 covering that. Short, setAndFetchFaviconForPage should just be setFaviconForPage.

There isn't a batch API for insertion, since for each icon there's various steps to convert it anyway, it wouldn't save much.
There isn't a batch API for insertion, since for each icon there's various steps to convert it anyway, it wouldn't save much.
There isn't a batch API for insertion, since for each icon there's various steps to resize/convert/undupe it anyway, it wouldn't save much.

Back to Bug 1790234 Comment 4